Fix dnx not authenticating for private feeds#53151
Fix dnx not authenticating for private feeds#53151robertcoltheart wants to merge 5 commits intodotnet:mainfrom
dnx not authenticating for private feeds#53151Conversation
iamteamstar
left a comment
iamteamstar
left a comment
There was a problem hiding this comment.
Despite this complexity, congratulations if you can solved the error.
|
Thanks for the analysis on the linked issue and this PR - I think it overlaps at least partially with a recently-merged change in #52787 - can you take a look and align your changes with this one to prevent merge conflicts? |
|
@baronfel Not sure I understand the branch targeting process - the linked PR hasn't been merged into |
|
Hi, first of all thank you for responding to my suggestions i am sure these
discussions will help us improve even more. To answer your question,
unfortunately, I cannot remember which PR you are referring to. However, I
can share the links I worked on for Git commands such as branch.
https://git-scm.com/book/tr/v2/Git-Dallar%C4%B1-K%C4%B1saca-Dalland%C4%B1rma-ve-Birle%C5%9Ftirme-Temelleri
***@***.***/ba%C5%9Far%C4%B1l%C4%B1-bir-git-branch-modeli-nas%C4%B1l-olu%C5%9Fturulur-e026e5cc24c2
https://www.youtube.com/watch?v=Uszj_k0DGsg
Robert Coltheart ***@***.***>, 3 Mar 2026 Sal, 00:13
tarihinde şunu yazdı:
… *robertcoltheart* left a comment (dotnet/sdk#53151)
<#53151 (comment)>
@baronfel <https://github.com/baronfel> Not sure I understand the branch
targetting process - the linked PR hasn't been merged into main yet,
should I wait for this to be back-merged to main before fixing this PR? Or
should I re-target this PR to the release/10.0.3xx branch instead?
—
Reply to this email directly, view it on GitHub
<#53151 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARXTQZZRSWZ4LCTHC23P4L34OX2OHAVCNFSM6AAAAACV7DNAI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSOBWHE2DEMZTG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
We have autoamted codeflow through the branches but the flow to main is typically the trickiest (as Nxx and main have the most combined changes). We're a bit behind getting unblocked there. Hopefully we can get this in over the next few days: #53007 and then you can remerge and fix any conflicts. |
|
Ok I will re-raise this PR against 10.0.3xx. Thanks for clarifying. |
|
Closing in favor of #53322 |
4 participants
Fixes #51375
For
dnxexecution (dotnet tool exec), if the package source is authenticated the previous method of passing an override source meant that the credentials are lost, since this is the equivalient of passing--source https://mysourceand ignoring any config inNuGet.config. We need to pass the explicit source fordnxbecause we confirm with the user that we will be downloading from a particular source (which may be authenticated).